Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Druid to use GCS Emulator for local setup & run e2e tests #741

Merged
merged 4 commits into from
Jan 1, 2025
Merged

Enable Druid to use GCS Emulator for local setup & run e2e tests #741

merged 4 commits into from
Jan 1, 2025

Conversation

anveshreddy18
Copy link
Contributor

@anveshreddy18 anveshreddy18 commented Jan 1, 2024 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/area testing
/kind test

What this PR does / why we need it:

This PR enables druid to run e2e tests for GCS locally with the help of a GCS Emulator called fake-gcs-server.

To run e2e tests with GCS Emulator as object store, do make ci-e2e-kind-gcs.

Which issue(s) this PR fixes:
Fixes #738

Special notes for your reviewer:

Release note:

Enable Druid to use GCS Emulator for local setup and running e2e tests using "make ci-e2e-kind-gcs"

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner January 1, 2024 11:58
@gardener-robot gardener-robot added needs/review Needs review area/dev-productivity Developer productivity related (how to improve development) area/testing Testing related kind/test Test labels Jan 1, 2024
@anveshreddy18 anveshreddy18 self-assigned this Jan 1, 2024
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jan 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 1, 2024
renormalize
renormalize requested changes Jan 2, 2024
View reviewed changes
hack/ci-gcs-e2e-kind.sh Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jan 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 3, 2024
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 4, 2024
@ishan16696 ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jan 4, 2024
@anveshreddy18 anveshreddy18 added the kind/enhancement Enhancement, improvement, extension label Jan 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 31, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 31, 2024
shreyas-s-rao
shreyas-s-rao requested changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anveshreddy18 thank you very much for enabling e2e tests to use fake-gcs to easily test against provider GCS. I have a few review comments. PTAL.

docs/deployment/getting-started-locally/manage-gcs-emulator.md Outdated Show resolved Hide resolved
docs/development/running-e2e-tests.md Outdated Show resolved Hide resolved
hack/ci-e2e-kind-gcs.sh Outdated Show resolved Hide resolved
hack/e2e-test/infrastructure/overlays/gcp/common/gcp.env Outdated Show resolved Hide resolved
hack/kind/cluster.yaml Outdated Show resolved Hide resolved
hack/ci-e2e-kind-gcs.sh Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 31, 2024
@anveshreddy18
Copy link
Contributor Author

/retest

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Dec 31, 2024 •
edited
Loading

@anveshreddy18: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-check-renovate-config fac1cbc link true /test pull-etcd-druid-check-renovate-config

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

shreyas-s-rao
shreyas-s-rao approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anveshreddy18 thanks for incorporating the changes and fixing the kind config generation! I've tested locally and it works perfectly!

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 1, 2025
@shreyas-s-rao shreyas-s-rao removed their assignment Jan 1, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 1, 2025
renormalize
renormalize approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anveshreddy18!

seshachalam-yv
seshachalam-yv approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anveshreddy18 for adding GCS emulator support
/lgtm

@anveshreddy18 anveshreddy18 changed the title Enable Druid to use mock GCS server to run e2e tests Enable Druid to use GCS Emulator for local setup & run e2e tests Jan 1, 2025
@anveshreddy18 anveshreddy18 merged commit abcc0ba into gardener:master Jan 1, 2025
13 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 1, 2025
@anveshreddy18 anveshreddy18 deleted the e2e/fake-gcs-server branch January 1, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@renormalize renormalize renormalize approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) area/testing Testing related kind/enhancement Enhancement, improvement, extension kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.

[Feature] Enable Druid to use mock GCS server to run e2e tests
9 participants
@anveshreddy18 @gardener-robot @seshachalam-yv @shreyas-s-rao @renormalize @gardener-robot-ci-1 @ishan16696 @gardener-robot-ci-2 @gardener-robot-ci-3